Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff50afe9 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/i915: WARN on !crtc in intel_dp_link_down 



This could have happened with the old crtc helper based modeset code,
but can't happen any longer with the new code.

Hence put in a WARN and adjust the comment. If no one hits this, we
can eventually remove it (like a few other such cases across our
code).

Reviewed-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent ab527efc

drivers/gpu/drm/i915/intel_dp.c

+4 −9
Original line number Diff line number Diff line
@@ -2098,15 +2098,10 @@ intel_dp_link_down(struct intel_dp *intel_dp) 
		/* Changes to enable or select take place the vblank

		 * after being written.

		 */

		if (crtc == NULL) {

			/* We can arrive here never having been attached

			 * to a CRTC, for instance, due to inheriting

			 * random state from the BIOS.

			 *

			 * If the pipe is not running, play safe and

			 * wait for the clocks to stabilise before

			 * continuing.

			 */

		if (WARN_ON(crtc == NULL)) {

			/* We should never try to disable a port without a crtc

			 * attached. For paranoia keep the code around for a

			 * bit. */

			POSTING_READ(intel_dp->output_reg);

			msleep(50);

		} else