Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit ff2faf12 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: dapm: delete dapm_kcontrol_data paths list before freeing it 



dapm_kcontrol_data is freed as part of dapm_kcontrol_free(), leaving the
paths pointer dangling in the list.

This leads to system crash when we try to unload and reload sound card.
I hit this bug during ADSP crash/reboot test case on Dragon board DB410c.

Without this patch, on SLAB Poisoning enabled build, kernel crashes with
"BUG kmalloc-128 (Tainted: G        W        ): Poison overwritten"

Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
parent 0c24fdc0

sound/soc/soc-dapm.c

+2 −0
Original line number Diff line number Diff line
@@ -433,6 +433,8 @@ static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget, 
static void dapm_kcontrol_free(struct snd_kcontrol *kctl)

{

	struct dapm_kcontrol_data *data = snd_kcontrol_chip(kctl);



	list_del(&data->paths);

	kfree(data->wlist);

	kfree(data);

}