Commit fe090e4e authored Jul 29, 2013 by Andi Shyti Committed by Steve French Jul 30, 2013

cifs: file: initialize oparms.reconnect before using it



In the cifs_reopen_file function, if the following statement is
asserted:

(tcon->unix_ext && cap_unix(tcon->ses) &&
            (CIFS_UNIX_POSIX_PATH_OPS_CAP &
            (tcon->fsUnixInfo.Capability)))

and we succeed to open with cifs_posix_open, the function jumps
to the label reopen_success and checks for oparms.reconnect
which is not initialized.

This issue has been reported by scan.coverity.com

Signed-off-by: Andi Shyti <andi@etezian.org>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>

parent 1b244081

fs/cifs/file.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -647,6 +647,7 @@ cifs_reopen_file(struct cifsFileInfo *cfile, bool can_flush)
		oflags, &oplock, &cfile->fid.netfid, xid);
		if (rc == 0) {
		cifs_dbg(FYI, "posix reopen succeeded\n");
		oparms.reconnect = true;
		goto reopen_success;
		}
		/*