Commit fdb4c0ad authored Oct 15, 2014 by Bruce Allan Committed by Herbert Xu Oct 24, 2014

crypto: qat - cleanup coccicheck warning - NULL check before freeing functions



Analyzing with coccinelle MODE=report...

Please check for false positives in the output before submitting a patch.
When using "patch" mode, carefully review the patch before submitting it.

drivers/crypto/qat/qat_dh895xcc/adf_isr.c:191:3-8: WARNING: NULL check
before freeing functions like kfree, debugfs_remove,
debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
reorganizing relevant code to avoid passing NULL values.

drivers/crypto/qat/qat_dh895xcc/adf_isr.c:208:3-8: WARNING: NULL check
before freeing functions like kfree, debugfs_remove,
debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
reorganizing relevant code to avoid passing NULL values.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 8c4cef46

drivers/crypto/qat/qat_dh895xcc/adf_isr.c

+4 −8

Original line number	Original line	Diff line number	Diff line
	@@ -186,10 +186,8 @@ static int adf_isr_alloc_msix_entry_table(struct adf_accel_dev *accel_dev)
	accel_dev->accel_pci_dev.msix_entries.names = names;		accel_dev->accel_pci_dev.msix_entries.names = names;
	return 0;		return 0;
	err:		err:
	for (i = 0; i < msix_num_entries; i++) {		for (i = 0; i < msix_num_entries; i++)
	if (*(names + i))
	kfree(*(names + i));		kfree(*(names + i));
	}
	kfree(entries);		kfree(entries);
	kfree(names);		kfree(names);
	return -ENOMEM;		return -ENOMEM;
	@@ -203,10 +201,8 @@ static void adf_isr_free_msix_entry_table(struct adf_accel_dev *accel_dev)
	int i;		int i;

	kfree(accel_dev->accel_pci_dev.msix_entries.entries);		kfree(accel_dev->accel_pci_dev.msix_entries.entries);
	for (i = 0; i < msix_num_entries; i++) {		for (i = 0; i < msix_num_entries; i++)
	if (*(names + i))
	kfree(*(names + i));		kfree(*(names + i));
	}
	kfree(names);		kfree(names);
	}		}