Commit fd4fb262 authored Aug 31, 2012 by Prasad Joshi Committed by Mark Brown Aug 31, 2012

ASoC: spear: correct the check for NULL dma_buffer pointer



The if condition
	if (!buf && !buf->area)

checks if the buf pointer is NULL and then dereferences it again to
check if the buffer area is NULL, resulting in possible NULL
dereference.

Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent c9219286

sound/soc/spear/spear_pcm.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -138,7 +138,7 @@ static void spear_pcm_free(struct snd_pcm *pcm)
	continue;		continue;

	buf = &substream->dma_buffer;		buf = &substream->dma_buffer;
	if (!buf && !buf->area)		if (!buf \|\| !buf->area)
	continue;		continue;

	dma_free_writecombine(pcm->card->dev, buf->bytes,		dma_free_writecombine(pcm->card->dev, buf->bytes,