Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fce4877a authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds
Browse files

tty: Fix USB kref leak 



When we close we must clear the extra reference we got when we read
port->tty. Setting the port tty NULL will clear the kref held by the driver
but not the one we obtained ourselves while doing the lookup.

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Tested-by: default avatarHelge Hafting <helge.hafting@aitel.hist.no>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0fb7f4f0

drivers/usb/serial/usb-serial.c

+1 −0
Original line number Diff line number Diff line
@@ -281,6 +281,7 @@ static void serial_close(struct tty_struct *tty, struct file *filp) 
			if (tty->driver_data)

				tty->driver_data = NULL;

			tty_port_tty_set(&port->port, NULL);

			tty_kref_put(tty);

		}

	}