Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcbc5459 authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by Jens Axboe
Browse files

nvmet: preserve controller serial number between reboots 



The NVMe target has no way to preserve controller serial
IDs across reboots which breaks udev scripts doing
SYMLINK+="dev/disk/by-id/nvme-$env{ID_SERIAL}-part%n.

Export the randomly generated serial number via configfs and allow
setting of a serial via configfs to mitigate this breakage.

Signed-off-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2e7f5d2a

drivers/nvme/target/configfs.c

+22 −0
Original line number Original line Diff line number Diff line
@@ -686,9 +686,31 @@ static ssize_t nvmet_subsys_attr_version_store(struct config_item *item, 
}

}

CONFIGFS_ATTR(nvmet_subsys_, attr_version);

CONFIGFS_ATTR(nvmet_subsys_, attr_version);





static ssize_t nvmet_subsys_attr_serial_show(struct config_item *item,

					     char *page)

{

	struct nvmet_subsys *subsys = to_subsys(item);



	return snprintf(page, PAGE_SIZE, "%llx\n", subsys->serial);

}



static ssize_t nvmet_subsys_attr_serial_store(struct config_item *item,

					      const char *page, size_t count)

{

	struct nvmet_subsys *subsys = to_subsys(item);



	down_write(&nvmet_config_sem);

	sscanf(page, "%llx\n", &subsys->serial);

	up_write(&nvmet_config_sem);



	return count;

}

CONFIGFS_ATTR(nvmet_subsys_, attr_serial);



static struct configfs_attribute *nvmet_subsys_attrs[] = {

static struct configfs_attribute *nvmet_subsys_attrs[] = {

	&nvmet_subsys_attr_attr_allow_any_host,

	&nvmet_subsys_attr_attr_allow_any_host,

	&nvmet_subsys_attr_attr_version,

	&nvmet_subsys_attr_attr_version,

	&nvmet_subsys_attr_attr_serial,

	NULL,

	NULL,

};

};