Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbc0ae20 authored by Alan Cox's avatar Alan Cox Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (11243): cx88: Missing failure checks 



The ioremap one was reported in October 2007 (Bug 9146), the kmalloc one
was blindingly obvious while looking at the ioremap one

The bug suggests some other configuration for lots of I/O memory (32MB per
device is ioremapped) but I'll leave that to the real maintainers

Signed-off-by: default avatarAlan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent c01f1a5a

drivers/media/video/cx88/cx88-cards.c

+7 −0
Original line number Diff line number Diff line
@@ -3127,6 +3127,8 @@ struct cx88_core *cx88_core_create(struct pci_dev *pci, int nr) 
	int i;



	core = kzalloc(sizeof(*core), GFP_KERNEL);

	if (core == NULL)

		return NULL;



	atomic_inc(&core->refcount);

	core->pci_bus  = pci->bus->number;
@@ -3157,6 +3159,11 @@ struct cx88_core *cx88_core_create(struct pci_dev *pci, int nr) 
			      pci_resource_len(pci, 0));

	core->bmmio = (u8 __iomem *)core->lmmio;



	if (core->lmmio == NULL) {

		kfree(core);

		return NULL;

	}



	/* board config */

	core->boardnr = UNSET;

	if (card[core->nr] < ARRAY_SIZE(cx88_boards))