Commit fae54158 authored Feb 02, 2016 by Mathieu Poirier Committed by Greg Kroah-Hartman Feb 07, 2016

coresight: coresight_unregister() function cleanup



In its current form the code never frees csdev->refcnt allocated
in coresight_register().  There is also a problem with csdev->conns
that is freed before device_unregister() rather than in the device
release function.

This patch addresses both issues by moving kfree(csdev->conns) to
coresight_device_release() and freeing csdev->refcnt, also in
the same function.

Reported-by: Rabin Vincent <rabin@rab.in>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a9ddc71f

drivers/hwtracing/coresight/coresight.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -481,6 +481,8 @@ static void coresight_device_release(struct device *dev)
		{
		struct coresight_device *csdev = to_coresight_device(dev);

		kfree(csdev->conns);
		kfree(csdev->refcnt);
		kfree(csdev);
		}

		@@ -713,7 +715,6 @@ EXPORT_SYMBOL_GPL(coresight_register);

		void coresight_unregister(struct coresight_device *csdev)
		{
		kfree(csdev->conns);
		device_unregister(&csdev->dev);
		}
		EXPORT_SYMBOL_GPL(coresight_unregister);