Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faaaba06 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij
Browse files

pinctrl: rza1: off by one in rza1_parse_gpiochip() 



The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements.  The > here
should be >= to prevent an out of bounds access.

Fixes: 5a49b644 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarJacopo Mondi <jacopo@jmondi.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 2c771084

drivers/pinctrl/pinctrl-rza1.c

+1 −1
Original line number Diff line number Diff line
@@ -1088,7 +1088,7 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl, 
	 */

	pinctrl_base = of_args.args[1];

	gpioport = RZA1_PIN_ID_TO_PORT(pinctrl_base);

	if (gpioport > RZA1_NPORTS) {

	if (gpioport >= RZA1_NPORTS) {

		dev_err(rza1_pctl->dev,

			"Invalid values in property %s\n", list_name);

		return -EINVAL;