Commit f9827dde authored Jul 08, 2013 by Kees Cook Committed by David Woodhouse Aug 05, 2013

mtd: refactor call to request_module



This reduces the size of the stack frame when calling request_module().
Performing the sprintf before the call is not needed.

Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

parent 2e294972

drivers/mtd/chips/gen_probe.c

+1 −3

Original line number	Original line	Diff line number	Diff line
	@@ -211,9 +211,7 @@ static inline struct mtd_info cfi_cmdset_unknown(struct map_info map,

	probe_function = __symbol_get(probename);		probe_function = __symbol_get(probename);
	if (!probe_function) {		if (!probe_function) {
	char modname[sizeof("cfi_cmdset_%4.4X")];		request_module("cfi_cmdset_%4.4X", type);
	sprintf(modname, "cfi_cmdset_%4.4X", type);
	request_module(modname);
	probe_function = __symbol_get(probename);		probe_function = __symbol_get(probename);
	}		}