Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit f91b1e73 authored by Fabio Estevam's avatar Fabio Estevam Committed by Mark Brown
Browse files

ASoC: soc-generic-dmaengine-pcm: Fix error handling 



When dmaengine_pcm_request_chan_of() fails it should release
the previously acquired resources, which in this case is to
call kfree(pcm), so jump to the correct point in the error
path.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4e363010

sound/soc/soc-generic-dmaengine-pcm.c

+2 −1
Original line number Diff line number Diff line
@@ -450,7 +450,7 @@ int snd_dmaengine_pcm_register(struct device *dev, 


	ret = dmaengine_pcm_request_chan_of(pcm, dev, config);

	if (ret)

		goto err_free_dma;

		goto err_free_pcm;



	ret = snd_soc_add_component(dev, &pcm->component,

				    &dmaengine_pcm_component, NULL, 0);
@@ -461,6 +461,7 @@ int snd_dmaengine_pcm_register(struct device *dev, 


err_free_dma:

	dmaengine_pcm_release_chan(pcm);

err_free_pcm:

	kfree(pcm);

	return ret;

}