Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8dacda9 authored by James Hilliard's avatar James Hilliard Committed by Greg Kroah-Hartman
Browse files

component: Silence bind error on -EPROBE_DEFER 



[ Upstream commit 7706b0a76a9697021e2bf395f3f065c18f51043d ]

If a component fails to bind due to -EPROBE_DEFER we should not log an
error as this is not a real failure.

Fixes messages like:
vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517
vc4-drm soc:gpu: master bind failed: -517

Signed-off-by: default avatarJames Hilliard <james.hilliard1@gmail.com>
Link: https://lore.kernel.org/r/20200411190241.89404-1-james.hilliard1@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 297a69f4

drivers/base/component.c

+5 −3
Original line number Diff line number Diff line
@@ -235,6 +235,7 @@ static int try_to_bring_up_master(struct master *master, 
	ret = master->ops->bind(master->dev);

	if (ret < 0) {

		devres_release_group(master->dev, NULL);

		if (ret != -EPROBE_DEFER)

			dev_info(master->dev, "master bind failed: %d\n", ret);

		return ret;

	}
@@ -506,6 +507,7 @@ static int component_bind(struct component *component, struct master *master, 
		devres_release_group(component->dev, NULL);

		devres_release_group(master->dev, NULL);



		if (ret != -EPROBE_DEFER)

			dev_err(master->dev, "failed to bind %s (ops %ps): %d\n",

				dev_name(component->dev), component->ops, ret);

	}