Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8b2ebb5 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf machine: Add threads__get_last_match function 



Separating threads::last_match cache read/check into separate
threads__get_last_match function. This will be useful in following
patch.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Lukasz Odzioba <lukasz.odzioba@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20180719143345.12963-2-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent e8fedff1

tools/perf/util/machine.c

+26 −13
Original line number Diff line number Diff line
@@ -407,24 +407,17 @@ static void machine__update_thread_pid(struct machine *machine, 
	goto out_put;

}



/*

 * Caller must eventually drop thread->refcnt returned with a successful

 * lookup/new thread inserted.

 */

static struct thread *____machine__findnew_thread(struct machine *machine,

						  struct threads *threads,

						  pid_t pid, pid_t tid,

						  bool create)

{

	struct rb_node **p = &threads->entries.rb_node;

	struct rb_node *parent = NULL;

	struct thread *th;



/*

 * Front-end cache - TID lookups come in blocks,

 * so most of the time we dont have to look up

 * the full rbtree:

 */

static struct thread*

threads__get_last_match(struct threads *threads, struct machine *machine,

			int pid, int tid)

{

	struct thread *th;



	th = threads->last_match;

	if (th != NULL) {

		if (th->tid == tid) {
@@ -435,6 +428,26 @@ static struct thread *____machine__findnew_thread(struct machine *machine, 
		threads->last_match = NULL;

	}



	return NULL;

}



/*

 * Caller must eventually drop thread->refcnt returned with a successful

 * lookup/new thread inserted.

 */

static struct thread *____machine__findnew_thread(struct machine *machine,

						  struct threads *threads,

						  pid_t pid, pid_t tid,

						  bool create)

{

	struct rb_node **p = &threads->entries.rb_node;

	struct rb_node *parent = NULL;

	struct thread *th;



	th = threads__get_last_match(threads, machine, pid, tid);

	if (th)

		return th;



	while (*p != NULL) {

		parent = *p;

		th = rb_entry(parent, struct thread, rb_node);