Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8947feb authored by LABBE Corentin's avatar LABBE Corentin Committed by Alexandre Belloni
Browse files

rtc: sunxi: fix signedness issues 



The variable year must be set as unsigned since it is used with
sunxi_rtc_data_year{.min|.max} and as parameter of is_leap_year() which
wait for unsigned int.
Only tm_year is not unsigned, but it is long.
This patch fix also the format of printing of min/max. (must use %u since
they are unsigned)

The parameter to of sunxi_rtc_setaie() must be set to uint since callers
give always uint data.

Signed-off-by: default avatarLABBE Corentin <clabbe.montjoie@gmail.com>
Acked-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 3fc2c14a

drivers/rtc/rtc-sunxi.c

+4 −4
Original line number Diff line number Diff line
@@ -175,7 +175,7 @@ static irqreturn_t sunxi_rtc_alarmirq(int irq, void *id) 
	return IRQ_NONE;

}



static void sunxi_rtc_setaie(int to, struct sunxi_rtc_dev *chip)

static void sunxi_rtc_setaie(unsigned int to, struct sunxi_rtc_dev *chip)

{

	u32 alrm_val = 0;

	u32 alrm_irq_val = 0;
@@ -343,7 +343,7 @@ static int sunxi_rtc_settime(struct device *dev, struct rtc_time *rtc_tm) 
	struct sunxi_rtc_dev *chip = dev_get_drvdata(dev);

	u32 date = 0;

	u32 time = 0;

	int year;

	unsigned int year;



	/*

	 * the input rtc_tm->tm_year is the offset relative to 1900. We use
@@ -353,7 +353,7 @@ static int sunxi_rtc_settime(struct device *dev, struct rtc_time *rtc_tm) 


	year = rtc_tm->tm_year + 1900;

	if (year < chip->data_year->min || year > chip->data_year->max) {

		dev_err(dev, "rtc only supports year in range %d - %d\n",

		dev_err(dev, "rtc only supports year in range %u - %u\n",

			chip->data_year->min, chip->data_year->max);

		return -EINVAL;

	}