Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7d86075 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Inki Dae
Browse files

drm/exynos: Fix fb_videomode <-> drm_mode_modeinfo conversion 



The fb_videomode structure stores the front porch and back porch in the
right_margin and left_margin fields respectively. right_margin should
thus be computed with hsync_start - hdisplay, and left_margin with
htotal - hsync_end. The same holds for the vertical direction.

       Active               Front           Sync            Back
       Region               Porch                           Porch
<-------------------><----------------><-------------><---------------->

  //////////////////|
 ////////////////// |
//////////////////  |..................               ..................
                                       _______________

<------ xres -------><- right_margin -><- hsync_len -><- left_margin -->

<---- hdisplay ----->
<------------ hsync_start ------------>
<--------------------- hsync_end -------------------->
<--------------------------------- htotal ----------------------------->

Fix the fb_videomode <-> drm_mode_modeinfo conversion functions
accordingly.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: default avatarJoonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
parent 0d8ce3ae

drivers/gpu/drm/exynos/exynos_drm_connector.c

+8 −8
Original line number Diff line number Diff line
@@ -54,14 +54,14 @@ convert_to_display_mode(struct drm_display_mode *mode, 
	mode->vrefresh = timing->refresh;



	mode->hdisplay = timing->xres;

	mode->hsync_start = mode->hdisplay + timing->left_margin;

	mode->hsync_start = mode->hdisplay + timing->right_margin;

	mode->hsync_end = mode->hsync_start + timing->hsync_len;

	mode->htotal = mode->hsync_end + timing->right_margin;

	mode->htotal = mode->hsync_end + timing->left_margin;



	mode->vdisplay = timing->yres;

	mode->vsync_start = mode->vdisplay + timing->upper_margin;

	mode->vsync_start = mode->vdisplay + timing->lower_margin;

	mode->vsync_end = mode->vsync_start + timing->vsync_len;

	mode->vtotal = mode->vsync_end + timing->lower_margin;

	mode->vtotal = mode->vsync_end + timing->upper_margin;

	mode->width_mm = panel->width_mm;

	mode->height_mm = panel->height_mm;
@@ -85,14 +85,14 @@ convert_to_video_timing(struct fb_videomode *timing, 
	timing->refresh = drm_mode_vrefresh(mode);



	timing->xres = mode->hdisplay;

	timing->left_margin = mode->hsync_start - mode->hdisplay;

	timing->right_margin = mode->hsync_start - mode->hdisplay;

	timing->hsync_len = mode->hsync_end - mode->hsync_start;

	timing->right_margin = mode->htotal - mode->hsync_end;

	timing->left_margin = mode->htotal - mode->hsync_end;



	timing->yres = mode->vdisplay;

	timing->upper_margin = mode->vsync_start - mode->vdisplay;

	timing->lower_margin = mode->vsync_start - mode->vdisplay;

	timing->vsync_len = mode->vsync_end - mode->vsync_start;

	timing->lower_margin = mode->vtotal - mode->vsync_end;

	timing->upper_margin = mode->vtotal - mode->vsync_end;



	if (mode->flags & DRM_MODE_FLAG_INTERLACE)

		timing->vmode = FB_VMODE_INTERLACED;