Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7c43950 authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: Use is_power_of_2() for clarity 



Signed-off-by: default avatarRobert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent c5ca7c76

fs/ext4/super.c

+2 −3
Original line number Diff line number Diff line
@@ -1483,7 +1483,7 @@ static int parse_options(char *options, struct super_block *sb, 
				return 0;

			if (option < 0 || option > (1 << 30))

				return 0;

			if (option & (option - 1)) {

			if (!is_power_of_2(option)) {

				printk(KERN_ERR "EXT4-fs: inode_readahead_blks"

				       " must be a power of 2\n");

				return 0;
@@ -2101,8 +2101,7 @@ static ssize_t inode_readahead_blks_store(struct ext4_attr *a, 
	if (parse_strtoul(buf, 0x40000000, &t))

		return -EINVAL;



	/* inode_readahead_blks must be a power of 2 */

	if (t & (t-1))

	if (!is_power_of_2(t))

		return -EINVAL;



	sbi->s_inode_readahead_blks = t;