Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6a835bb authored by Gao feng's avatar Gao feng Committed by David S. Miller
Browse files

vsock: fix missing cleanup when misc_register failed



reset transport and unlock if misc_register failed.

Signed-off-by: default avatarGao feng <omarapazanadi@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 10be15ff
Loading
Loading
Loading
Loading
+4 −3
Original line number Diff line number Diff line
@@ -1948,13 +1948,13 @@ int __vsock_core_init(const struct vsock_transport *t, struct module *owner)
	err = misc_register(&vsock_device);
	if (err) {
		pr_err("Failed to register misc device\n");
		return -ENOENT;
		goto err_reset_transport;
	}

	err = proto_register(&vsock_proto, 1);	/* we want our slab */
	if (err) {
		pr_err("Cannot register vsock protocol\n");
		goto err_misc_deregister;
		goto err_deregister_misc;
	}

	err = sock_register(&vsock_family_ops);
@@ -1969,8 +1969,9 @@ int __vsock_core_init(const struct vsock_transport *t, struct module *owner)

err_unregister_proto:
	proto_unregister(&vsock_proto);
err_misc_deregister:
err_deregister_misc:
	misc_deregister(&vsock_device);
err_reset_transport:
	transport = NULL;
err_busy:
	mutex_unlock(&vsock_register_mutex);