Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f69ae4f5 authored by Charles Keepax's avatar Charles Keepax Committed by Krzysztof Kozlowski
Browse files

pinctrl: samsung: Use devres version of gpiochip_add_data 



Use devm_gpiochip_add_data to simplify the error path in
samsung_gpiolib_register.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
parent 1abd18d1

drivers/pinctrl/samsung/pinctrl-samsung.c

+2 −7
Original line number Diff line number Diff line
@@ -936,20 +936,15 @@ static int samsung_gpiolib_register(struct platform_device *pdev, 
		gc->of_node = bank->of_node;

		gc->label = bank->name;



		ret = gpiochip_add_data(gc, bank);

		ret = devm_gpiochip_add_data(&pdev->dev, gc, bank);

		if (ret) {

			dev_err(&pdev->dev, "failed to register gpio_chip %s, error code: %d\n",

							gc->label, ret);

			goto fail;

			return ret;

		}

	}



	return 0;



fail:

	for (--i, --bank; i >= 0; --i, --bank)

		gpiochip_remove(&bank->gpio_chip);

	return ret;

}



/* retrieve the soc specific data */