Commit f5d8edaf authored Feb 12, 2013 by Ezequiel Garcia Committed by Jon Hunter Apr 01, 2013

ARM: omap2: gpmc: Remove redundant chip select out of range check



This check is done before the call to gpmc_cs_reserved() and
gpmc_cs_set_reserved() and it's redundant to do it again in each
function. This simplifies the code a bit.

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Reviewed-by: Jon Hunter <jon-hunter@ti.com>
Signed-off-by: Jon Hunter <jon-hunter@ti.com>

parent 7ab91596

arch/arm/mach-omap2/gpmc.c

+1 −9

Original line number	Diff line number	Diff line
		@@ -441,22 +441,14 @@ static int gpmc_cs_mem_enabled(int cs)
		return l & GPMC_CONFIG7_CSVALID;
		}

		static int gpmc_cs_set_reserved(int cs, int reserved)
		static void gpmc_cs_set_reserved(int cs, int reserved)
		{
		if (cs > GPMC_CS_NUM)
		return -ENODEV;

		gpmc_cs_map &= ~(1 << cs);
		gpmc_cs_map \|= (reserved ? 1 : 0) << cs;

		return 0;
		}

		static bool gpmc_cs_reserved(int cs)
		{
		if (cs > GPMC_CS_NUM)
		return true;

		return gpmc_cs_map & (1 << cs);
		}