Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f575f658 authored by Bing Zhao's avatar Bing Zhao Committed by John W. Linville
Browse files

mwifiex: use sizeof(array) to print_hex_dump_bytes 



DBG_CMD_NUM is the number of commands, not the actual bytes of
data for printing.

Also remove the duplicated DBG_CMD_NUM definition.

Reported-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 7a66205a

drivers/net/wireless/mwifiex/cmdevt.c

+7 −4
Original line number Diff line number Diff line
@@ -918,20 +918,23 @@ mwifiex_cmd_timeout_func(unsigned long function_context) 
		dev_err(adapter->dev, "last_cmd_index = %d\n",

			adapter->dbg.last_cmd_index);

		print_hex_dump_bytes("last_cmd_id: ", DUMP_PREFIX_OFFSET,

				     adapter->dbg.last_cmd_id, DBG_CMD_NUM);

				     adapter->dbg.last_cmd_id,

				     sizeof(adapter->dbg.last_cmd_id));

		print_hex_dump_bytes("last_cmd_act: ", DUMP_PREFIX_OFFSET,

				     adapter->dbg.last_cmd_act, DBG_CMD_NUM);

				     adapter->dbg.last_cmd_act,

				     sizeof(adapter->dbg.last_cmd_act));



		dev_err(adapter->dev, "last_cmd_resp_index = %d\n",

			adapter->dbg.last_cmd_resp_index);

		print_hex_dump_bytes("last_cmd_resp_id: ", DUMP_PREFIX_OFFSET,

				     adapter->dbg.last_cmd_resp_id,

				     DBG_CMD_NUM);

				     sizeof(adapter->dbg.last_cmd_resp_id));



		dev_err(adapter->dev, "last_event_index = %d\n",

			adapter->dbg.last_event_index);

		print_hex_dump_bytes("last_event: ", DUMP_PREFIX_OFFSET,

				     adapter->dbg.last_event, DBG_CMD_NUM);

				     adapter->dbg.last_event,

				     sizeof(adapter->dbg.last_event));



		dev_err(adapter->dev, "data_sent=%d cmd_sent=%d\n",

			adapter->data_sent, adapter->cmd_sent);

drivers/net/wireless/mwifiex/main.h

+0 −2
Original line number Diff line number Diff line
@@ -115,8 +115,6 @@ enum { 
#define MWIFIEX_TYPE_DATA				0

#define MWIFIEX_TYPE_EVENT				3



#define DBG_CMD_NUM						5



#define MAX_BITMAP_RATES_SIZE			10



#define MAX_CHANNEL_BAND_BG     14