Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5592268 authored by Harvey Harrison's avatar Harvey Harrison Committed by Linus Torvalds
Browse files

char: fix sparse shadowed variable warnings in esp.c 



flags only use was in spin_lock_irqsave/spin_lock_irgrestore pairs, no
need to redeclare for each one.

drivers/char/esp.c:1599:17: warning: symbol 'flags' shadows an earlier one
drivers/char/esp.c:1517:16: originally declared here
drivers/char/esp.c:1615:17: warning: symbol 'flags' shadows an earlier one
drivers/char/esp.c:1517:16: originally declared here
drivers/char/esp.c:1631:17: warning: symbol 'flags' shadows an earlier one
drivers/char/esp.c:1517:16: originally declared here

Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ec09cd56

drivers/char/esp.c

+0 −6
Original line number Diff line number Diff line
@@ -1600,8 +1600,6 @@ static int set_esp_config(struct esp_struct * info, 


	if ((new_config.flow_off != info->config.flow_off) ||

	    (new_config.flow_on != info->config.flow_on)) {

		unsigned long flags;



		info->config.flow_off = new_config.flow_off;

		info->config.flow_on = new_config.flow_on;
@@ -1616,8 +1614,6 @@ static int set_esp_config(struct esp_struct * info, 


	if ((new_config.rx_trigger != info->config.rx_trigger) ||

	    (new_config.tx_trigger != info->config.tx_trigger)) {

		unsigned long flags;



		info->config.rx_trigger = new_config.rx_trigger;

		info->config.tx_trigger = new_config.tx_trigger;

		spin_lock_irqsave(&info->lock, flags);
@@ -1632,8 +1628,6 @@ static int set_esp_config(struct esp_struct * info, 
	}



	if (new_config.rx_timeout != info->config.rx_timeout) {

		unsigned long flags;



		info->config.rx_timeout = new_config.rx_timeout;

		spin_lock_irqsave(&info->lock, flags);