Commit f53ad3e1 authored Jul 24, 2018 by Gilad Ben-Yossef Committed by Herbert Xu Aug 03, 2018

crypto: ccree - allow bigger than sector XTS op



The ccree driver had a sanity check that we are not asked
to encrypt an XTS buffer bigger than a sane sector size
since XTS IV needs to include the sector number in the IV
so this is not expected in any real use case.

Unfortunately, this breaks cryptsetup benchmark test which
has a synthetic performance test using 64k buffer of data
with the same IV.

Remove the sanity check and allow the user to hang themselves
and/or run benchmarks if they so wish.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent e30368f3

drivers/crypto/ccree/cc_cipher.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -19,8 +19,6 @@

		#define template_skcipher template_u.skcipher

		#define CC_MIN_AES_XTS_SIZE 0x10
		#define CC_MAX_AES_XTS_SIZE 0x2000
		struct cc_cipher_handle {
		struct list_head alg_list;
		};
		@@ -98,8 +96,7 @@ static int validate_data_size(struct cc_cipher_ctx *ctx_p,
		case S_DIN_to_AES:
		switch (ctx_p->cipher_mode) {
		case DRV_CIPHER_XTS:
		if (size >= CC_MIN_AES_XTS_SIZE &&
		size <= CC_MAX_AES_XTS_SIZE &&
		if (size >= AES_BLOCK_SIZE &&
		IS_ALIGNED(size, AES_BLOCK_SIZE))
		return 0;
		break;