Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f317dfeb authored by Wolfram Sang's avatar Wolfram Sang Committed by Chris Ball
Browse files

mmc: core: fix memory leak in mmc_add_host 



led_trigger_register_simple() allocates memory which must not be leaked
in the error-path of mmc_add_host. Move it past the only error-check in
the function.

Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
Signed-off-by: default avatarChris Ball <cjb@laptop.org>
parent b177bc91

drivers/mmc/core/host.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -324,12 +324,12 @@ int mmc_add_host(struct mmc_host *host) 
	WARN_ON((host->caps & MMC_CAP_SDIO_IRQ) &&

	WARN_ON((host->caps & MMC_CAP_SDIO_IRQ) &&

		!host->ops->enable_sdio_irq);

		!host->ops->enable_sdio_irq);





	led_trigger_register_simple(dev_name(&host->class_dev), &host->led);



	err = device_add(&host->class_dev);

	err = device_add(&host->class_dev);

	if (err)

	if (err)

		return err;

		return err;





	led_trigger_register_simple(dev_name(&host->class_dev), &host->led);



#ifdef CONFIG_DEBUG_FS

#ifdef CONFIG_DEBUG_FS

	mmc_add_host_debugfs(host);

	mmc_add_host_debugfs(host);

#endif

#endif