Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0af7899 authored by Bruno Prémont's avatar Bruno Prémont Committed by Richard Purdie
Browse files

backlight: classmate-laptop - Fix missing registration failure handling 



Check newly registered backlight_device for error and properly
return error to parent.
Mark struct backlight_ops as const.

Signed-off-by: default avatarBruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: default avatarRichard Purdie <rpurdie@linux.intel.com>
parent 36bc5ee6

drivers/platform/x86/classmate-laptop.c

+3 −1
Original line number Diff line number Diff line
@@ -455,7 +455,7 @@ static int cmpc_bl_update_status(struct backlight_device *bd) 
		return -1;

}



static struct backlight_ops cmpc_bl_ops = {

static const struct backlight_ops cmpc_bl_ops = {

	.get_brightness = cmpc_bl_get_brightness,

	.update_status = cmpc_bl_update_status

};
@@ -469,6 +469,8 @@ static int cmpc_bl_add(struct acpi_device *acpi) 
	props.max_brightness = 7;

	bd = backlight_device_register("cmpc_bl", &acpi->dev, acpi->handle,

				       &cmpc_bl_ops, &props);

	if (IS_ERR(bd))

		return PTR_ERR(bd);

	dev_set_drvdata(&acpi->dev, bd);

	return 0;

}