Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef743fdd authored by Or Gerlitz's avatar Or Gerlitz Committed by David S. Miller
Browse files

mlxsw: Put constant on the right side of comparisons 



Fixes those places where checkpatch complains that comparisons
should place the constant on the right side of the test.

Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 135f9ece

drivers/net/ethernet/mellanox/mlxsw/core.c

+2 −2
Original line number Diff line number Diff line
@@ -287,7 +287,7 @@ static void mlxsw_emad_pack_op_tlv(char *op_tlv, 
	mlxsw_emad_op_tlv_status_set(op_tlv, 0);

	mlxsw_emad_op_tlv_register_id_set(op_tlv, reg->id);

	mlxsw_emad_op_tlv_r_set(op_tlv, MLXSW_EMAD_OP_TLV_REQUEST);

	if (MLXSW_CORE_REG_ACCESS_TYPE_QUERY == type)

	if (type == MLXSW_CORE_REG_ACCESS_TYPE_QUERY)

		mlxsw_emad_op_tlv_method_set(op_tlv,

					     MLXSW_EMAD_OP_TLV_METHOD_QUERY);

	else
@@ -362,7 +362,7 @@ static bool mlxsw_emad_is_resp(const struct sk_buff *skb) 
	char *op_tlv;



	op_tlv = mlxsw_emad_op_tlv(skb);

	return (MLXSW_EMAD_OP_TLV_RESPONSE == mlxsw_emad_op_tlv_r_get(op_tlv));

	return (mlxsw_emad_op_tlv_r_get(op_tlv) == MLXSW_EMAD_OP_TLV_RESPONSE);

}



#define MLXSW_EMAD_TIMEOUT_MS 200

drivers/net/ethernet/mellanox/mlxsw/switchx2.c

+1 −1
Original line number Diff line number Diff line
@@ -1147,7 +1147,7 @@ static void mlxsw_sx_pude_event_func(const struct mlxsw_reg_info *reg, 
	}



	status = mlxsw_reg_pude_oper_status_get(pude_pl);

	if (MLXSW_PORT_OPER_STATUS_UP == status) {

	if (status == MLXSW_PORT_OPER_STATUS_UP) {

		netdev_info(mlxsw_sx_port->dev, "link up\n");

		netif_carrier_on(mlxsw_sx_port->dev);

	} else {