Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef07991a authored by Hauke Mehrtens's avatar Hauke Mehrtens Committed by Bjorn Helgaas
Browse files

PCI: iproc: Free resource list after registration 



The resource list is only used in the setup process and was never freed.
pci_add_resource() allocates a memory area to store the list item.

Fix the memory leak.

Tested-by: default avatarRay Jui <rjui@broadcom.com>
Signed-off-by: default avatarHauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarRay Jui <rjui@broadcom.com>
parent 18c4342a

drivers/pci/host/pcie-iproc-bcma.c

+4 −4
Original line number Diff line number Diff line
@@ -65,12 +65,12 @@ static int iproc_pcie_bcma_probe(struct bcma_device *bdev) 
	pcie->map_irq = iproc_pcie_bcma_map_irq;



	ret = iproc_pcie_setup(pcie, &res);

	if (ret) {

	if (ret)

		dev_err(pcie->dev, "PCIe controller setup failed\n");

		return ret;

	}



	return 0;

	pci_free_resource_list(&res);



	return ret;

}



static void iproc_pcie_bcma_remove(struct bcma_device *bdev)

drivers/pci/host/pcie-iproc-platform.c

+4 −4
Original line number Diff line number Diff line
@@ -72,12 +72,12 @@ static int iproc_pcie_pltfm_probe(struct platform_device *pdev) 
	pcie->map_irq = of_irq_parse_and_map_pci;



	ret = iproc_pcie_setup(pcie, &res);

	if (ret) {

	if (ret)

		dev_err(pcie->dev, "PCIe controller setup failed\n");

		return ret;

	}



	return 0;

	pci_free_resource_list(&res);



	return ret;

}



static int iproc_pcie_pltfm_remove(struct platform_device *pdev)