Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee061da8 authored by Andrew Lutomirski's avatar Andrew Lutomirski Committed by Rafael J. Wysocki
Browse files

PM / QoS: Improve sysfs pm_qos_latency_tolerance validation 



Negative values are special.  Don't let users write them directly.

Signed-off-by: default avatarAndy Lutomirski <luto@kernel.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent e5517c2a

drivers/base/power/sysfs.c

+5 −1
Original line number Diff line number Diff line
@@ -263,7 +263,11 @@ static ssize_t pm_qos_latency_tolerance_store(struct device *dev, 
	s32 value;

	int ret;



	if (kstrtos32(buf, 0, &value)) {

	if (kstrtos32(buf, 0, &value) == 0) {

		/* Users can't write negative values directly */

		if (value < 0)

			return -EINVAL;

	} else {

		if (!strcmp(buf, "auto") || !strcmp(buf, "auto\n"))

			value = PM_QOS_LATENCY_TOLERANCE_NO_CONSTRAINT;

		else if (!strcmp(buf, "any") || !strcmp(buf, "any\n"))