Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eda910e4 authored by Dolev Raviv's avatar Dolev Raviv Committed by Christoph Hellwig
Browse files

scsi: ufs: fix static checker warning in __ufshcd_setup_clocks 



This patch fixes newly introduced static checker warning in
__ufshcd_setup_clocks, introduced by UFS power management series.

Warning:
drivers/scsi/ufs/ufshcd.c:4474 __ufshcd_setup_clocks()
warn: we tested 'ret' before and it was 'false'

To fix it we remove the (!ret) from the condition.

Signed-off-by: default avatarDolev Raviv <draviv@codeaurora.org>
Reviewed-by: default avatarMaya Erez <merez@codeaurora.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 758581b9

drivers/scsi/ufs/ufshcd.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -4473,7 +4473,7 @@ static int __ufshcd_setup_clocks(struct ufs_hba *hba, bool on, 
			if (!IS_ERR_OR_NULL(clki->clk) && clki->enabled)

			if (!IS_ERR_OR_NULL(clki->clk) && clki->enabled)

				clk_disable_unprepare(clki->clk);

				clk_disable_unprepare(clki->clk);

		}

		}

	} else if (!ret && on) {

	} else if (on) {

		spin_lock_irqsave(hba->host->host_lock, flags);

		spin_lock_irqsave(hba->host->host_lock, flags);

		hba->clk_gating.state = CLKS_ON;

		hba->clk_gating.state = CLKS_ON;

		spin_unlock_irqrestore(hba->host->host_lock, flags);

		spin_unlock_irqrestore(hba->host->host_lock, flags);