Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed97d0cd authored by Andy Grover's avatar Andy Grover Committed by Nicholas Bellinger
Browse files

target/user: Fix UFLAG_UNKNOWN_OP handling 



Calling transport_generic_request_failure() from here causes list
corruption. We should be using target_complete_cmd() instead.

Which we do in all other cases, so the UNKNOWN_OP case can become just
another member of the big else/if chain in tcmu_handle_completion().

Signed-off-by: default avatarAndy Grover <agrover@redhat.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 06b967e4

drivers/target/target_core_user.c

+2 −8
Original line number Diff line number Diff line
@@ -538,14 +538,8 @@ static void tcmu_handle_completion(struct tcmu_cmd *cmd, struct tcmu_cmd_entry * 
		UPDATE_HEAD(udev->data_tail, cmd->data_length, udev->data_size);

		pr_warn("TCMU: Userspace set UNKNOWN_OP flag on se_cmd %p\n",

			cmd->se_cmd);

		transport_generic_request_failure(cmd->se_cmd,

			TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE);

		cmd->se_cmd = NULL;

		kmem_cache_free(tcmu_cmd_cache, cmd);

		return;

	}



	if (entry->rsp.scsi_status == SAM_STAT_CHECK_CONDITION) {

		entry->rsp.scsi_status = SAM_STAT_CHECK_CONDITION;

	} else if (entry->rsp.scsi_status == SAM_STAT_CHECK_CONDITION) {

		memcpy(se_cmd->sense_buffer, entry->rsp.sense_buffer,

			       se_cmd->scsi_sense_length);