Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed13c27e authored by Chuck Lever's avatar Chuck Lever Committed by Trond Myklebust
Browse files

SUNRPC: Fix a memory leak in rpc_create() 



Commit 510deb0d was supposed to move the xprt_create_transport() call in
rpc_create(), but neglected to remove the old call site.  This resulted in
a transport leak after every rpc_create() call.

This leak is present in 2.6.24 and 2.6.25.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 240ee831

net/sunrpc/clnt.c

+0 −4
Original line number Diff line number Diff line
@@ -261,10 +261,6 @@ struct rpc_clnt *rpc_create(struct rpc_create_args *args) 
	};

	char servername[48];



	xprt = xprt_create_transport(&xprtargs);

	if (IS_ERR(xprt))

		return (struct rpc_clnt *)xprt;



	/*

	 * If the caller chooses not to specify a hostname, whip

	 * up a string representation of the passed-in address.