Commit ecca0683 authored Jul 11, 2009 by Julia Lawall Committed by Dave Airlie Jul 15, 2009

drm: Move a dereference below a NULL test

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Dave Airlie <airlied@linux.ie>

parent ba0ab823

drivers/gpu/drm/drm_stub.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -489,7 +489,7 @@ int drm_put_minor(struct drm_minor **minor_p)
		*/
		void drm_put_dev(struct drm_device *dev)
		{
		struct drm_driver *driver = dev->driver;
		struct drm_driver *driver;
		struct drm_map_list r_list, list_temp;

		DRM_DEBUG("\n");
		@@ -498,6 +498,7 @@ void drm_put_dev(struct drm_device *dev)
		DRM_ERROR("cleanup called no dev\n");
		return;
		}
		driver = dev->driver;

		drm_vblank_cleanup(dev);