Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecbfa8ea authored by Boris Brezillon's avatar Boris Brezillon Committed by Richard Weinberger
Browse files

UBI: fastmap: scrub PEB when bitflips are detected in a free PEB EC header 



scan_pool() does not mark the PEB for scrubing when bitflips are
detected in the EC header of a free PEB (VID header region left to
0xff).
Make sure we scrub the PEB in this case.

Signed-off-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
Fixes: dbb7d2a8 ("UBI: Add fastmap core")
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 4c368421

drivers/mtd/ubi/fastmap.c

+4 −3
Original line number Diff line number Diff line
@@ -498,10 +498,11 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai, 
			unsigned long long ec = be64_to_cpu(ech->ec);

			unmap_peb(ai, pnum);

			dbg_bld("Adding PEB to free: %i", pnum);



			if (err == UBI_IO_FF_BITFLIPS)

				add_aeb(ai, free, pnum, ec, 1);

			else

				add_aeb(ai, free, pnum, ec, 0);

				scrub = 1;



			add_aeb(ai, free, pnum, ec, scrub);

			continue;

		} else if (err == 0 || err == UBI_IO_BITFLIPS) {

			dbg_bld("Found non empty PEB:%i in pool", pnum);