Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ec9ee8e2 authored by James Hogan's avatar James Hogan Committed by Mauro Carvalho Chehab
Browse files

[media] media: ir-sony-decoder: 15bit function decode fix 



The raw Sony IR decoder decodes 15bit messages slightly incorrectly.
To decode the function number, it shifts the bits right by 7 so that the
function is in bits 7:1, masks with 0xFD (0b11111101), and does an 8 bit
reverse so it ends up in bits 6:0. The mask should be 0xFE to correspond
with bits 7:1 (0b11111110).

The old mask had the effect of dropping the MSB of the function number
from bit 6, and leaving the LSB of the device number in bit 7.

Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent fd0f6851

drivers/media/rc/ir-sony-decoder.c

+1 −1
Original line number Diff line number Diff line
@@ -130,7 +130,7 @@ static int ir_sony_decode(struct rc_dev *dev, struct ir_raw_event ev) 
		case 15:

			device    = bitrev8((data->bits >>  0) & 0xFF);

			subdevice = 0;

			function  = bitrev8((data->bits >>  7) & 0xFD);

			function  = bitrev8((data->bits >>  7) & 0xFE);

			break;

		case 20:

			device    = bitrev8((data->bits >>  5) & 0xF8);