Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ec5d241b authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Joerg Roedel
Browse files

iommu/exynos: Improve page fault debug message 



Add master device name to default IOMMU fault message to make easier to
find which device triggered the fault. While at it, move printing some
information (like page table base and first level entry addresses) to
dev_dbg(), because those are typically not very useful for typical device
driver user/developer not equipped with hardware debugging tools.

Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 2f5f44f2

drivers/iommu/exynos-iommu.c

+5 −4
Original line number Diff line number Diff line
@@ -381,13 +381,14 @@ static void show_fault_information(struct sysmmu_drvdata *data, 
{

	sysmmu_pte_t *ent;



	dev_err(data->sysmmu, "%s FAULT occurred at %#x (page table base: %pa)\n",

		finfo->name, fault_addr, &data->pgtable);

	dev_err(data->sysmmu, "%s: %s FAULT occurred at %#x\n",

		dev_name(data->master), finfo->name, fault_addr);

	dev_dbg(data->sysmmu, "Page table base: %pa\n", &data->pgtable);

	ent = section_entry(phys_to_virt(data->pgtable), fault_addr);

	dev_err(data->sysmmu, "\tLv1 entry: %#x\n", *ent);

	dev_dbg(data->sysmmu, "\tLv1 entry: %#x\n", *ent);

	if (lv1ent_page(ent)) {

		ent = page_entry(ent, fault_addr);

		dev_err(data->sysmmu, "\t Lv2 entry: %#x\n", *ent);

		dev_dbg(data->sysmmu, "\t Lv2 entry: %#x\n", *ent);

	}

}