Commit ec572e3f authored Jul 12, 2006 by Eric W. Biederman Committed by Linus Torvalds Jul 12, 2006

[PATCH] msi: Only keep one msi_desc in each slab entry.



It looks like someone confused kmem_cache_create with a different allocator
and was attempting to give it knowledge of how many cache entries there
were.

With the unfortunate result that each slab entry was big enough to hold
every irq.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 0635170b

drivers/pci/msi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -47,13 +47,13 @@ msi_register(struct msi_ops *ops)

		static void msi_cache_ctor(void p, kmem_cache_t cache, unsigned long flags)
		{
		memset(p, 0, NR_IRQS * sizeof(struct msi_desc));
		memset(p, 0, sizeof(struct msi_desc));
		}

		static int msi_cache_init(void)
		{
		msi_cachep = kmem_cache_create("msi_cache",
		NR_IRQS * sizeof(struct msi_desc),
		sizeof(struct msi_desc),
		0, SLAB_HWCACHE_ALIGN, msi_cache_ctor, NULL);
		if (!msi_cachep)
		return -ENOMEM;