Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ebdc1b88 authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman
Browse files

staging: unisys: visorbus: remove POSTCODE from create_visor_device 



Remove POSTCODES from create_visor_device, when we fail log an error
with dev_err.

Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Reviewed-by: default avatarTim Sell <timothy.sell@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8c8c975f

drivers/staging/unisys/visorbus/visorbus_main.c

+2 −7
Original line number Original line Diff line number Diff line
@@ -626,9 +626,6 @@ create_visor_device(struct visor_device *dev) 
	u32 chipset_bus_no = dev->chipset_bus_no;

	u32 chipset_bus_no = dev->chipset_bus_no;

	u32 chipset_dev_no = dev->chipset_dev_no;

	u32 chipset_dev_no = dev->chipset_dev_no;





	POSTCODE_LINUX(DEVICE_CREATE_ENTRY_PC, chipset_dev_no, chipset_bus_no,

		       DIAG_SEVERITY_PRINT);



	mutex_init(&dev->visordriver_callback_lock);

	mutex_init(&dev->visordriver_callback_lock);

	dev->device.bus = &visorbus_type;

	dev->device.bus = &visorbus_type;

	dev->device.groups = visorbus_channel_groups;

	dev->device.groups = visorbus_channel_groups;
@@ -666,17 +663,15 @@ create_visor_device(struct visor_device *dev) 
	 *  bus_type.klist_devices regardless (use bus_for_each_dev).

	 *  bus_type.klist_devices regardless (use bus_for_each_dev).

	 */

	 */

	err = device_add(&dev->device);

	err = device_add(&dev->device);

	if (err < 0) {

	if (err < 0)

		POSTCODE_LINUX(DEVICE_ADD_PC, 0, chipset_bus_no,

			       DIAG_SEVERITY_ERR);

		goto err_put;

		goto err_put;

	}





	list_add_tail(&dev->list_all, &list_all_device_instances);

	list_add_tail(&dev->list_all, &list_all_device_instances);

	return 0; /* success: reference kept via unmatched get_device() */

	return 0; /* success: reference kept via unmatched get_device() */





err_put:

err_put:

	put_device(&dev->device);

	put_device(&dev->device);

	dev_err(&dev->device, "Creating visor device failed. %d\n", err);

	return err;

	return err;

}

}