Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb6ff239 authored by Joel Becker's avatar Joel Becker Committed by Mark Fasheh
Browse files

ocfs2: Specify appropriate journal access for new xattr buckets. 



There are a couple places that get an xattr bucket that may be reading
an existing one or may be allocating a new one.  They should specify the
correct journal access mode depending.

Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
Signed-off-by: default avatarMark Fasheh <mfasheh@suse.com>
parent bd60bd37

fs/ocfs2/xattr.c

+5 −1
Original line number Diff line number Diff line
@@ -3231,7 +3231,9 @@ static int ocfs2_half_xattr_bucket(struct inode *inode, 


	for (i = 0; i < blk_per_bucket; i++) {

		ret = ocfs2_journal_access(handle, inode, t_bhs[i],

					   OCFS2_JOURNAL_ACCESS_CREATE);

					   new_bucket_head ?

					   OCFS2_JOURNAL_ACCESS_CREATE :

					   OCFS2_JOURNAL_ACCESS_WRITE);

		if (ret) {

			mlog_errno(ret);

			goto out;
@@ -3393,6 +3395,8 @@ static int ocfs2_cp_xattr_bucket(struct inode *inode, 


	for (i = 0; i < blk_per_bucket; i++) {

		ret = ocfs2_journal_access(handle, inode, t_bhs[i],

					   t_is_new ?

					   OCFS2_JOURNAL_ACCESS_CREATE :

					   OCFS2_JOURNAL_ACCESS_WRITE);

		if (ret)

			goto out;