Commit eb3fe263 authored Aug 23, 2017 by Shivasharan S Committed by Martin K. Petersen Aug 24, 2017

scsi: megaraid_sas: Return pended IOCTLs with cmd_status MFI_STAT_WRONG_STATE...


scsi: megaraid_sas: Return pended IOCTLs with cmd_status MFI_STAT_WRONG_STATE in case adapter is dead

After a kill adapter, since the cmd_status is not set, the IOCTLs will
be hung in driver resulting in application hang.  Set cmd_status
MFI_STAT_WRONG_STATE when completing pended IOCTLs.

Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Cc: stable@vger.kernel.org
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent def3e8df

drivers/scsi/megaraid/megaraid_sas_base.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1996,11 +1996,14 @@ static void megasas_complete_outstanding_ioctls(struct megasas_instance *instanc
		if (cmd_fusion->sync_cmd_idx != (u32)ULONG_MAX) {
		cmd_mfi = instance->cmd_list[cmd_fusion->sync_cmd_idx];
		if (cmd_mfi->sync_cmd &&
		cmd_mfi->frame->hdr.cmd != MFI_CMD_ABORT)
		(cmd_mfi->frame->hdr.cmd != MFI_CMD_ABORT)) {
		cmd_mfi->frame->hdr.cmd_status =
		MFI_STAT_WRONG_STATE;
		megasas_complete_cmd(instance,
		cmd_mfi, DID_OK);
		}
		}
		}
		} else {
		for (i = 0; i < instance->max_fw_cmds; i++) {
		cmd_mfi = instance->cmd_list[i];