Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea3651fe authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Bjorn Helgaas
Browse files

PCI: keystone: Fix error handling of irq_of_parse_and_map() 



Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating
failure, so testing for negative result never works.

Signed-off-by: default avatarDmitry Torokhov <dtor@chromium.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-By: default avatarMurali Karicheri <m-karicheri2@ti.com>
parent 97bf6af1

drivers/pci/host/pci-keystone.c

+1 −1
Original line number Diff line number Diff line
@@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie, 
	 */

	for (temp = 0; temp < max_host_irqs; temp++) {

		host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);

		if (host_irqs[temp] < 0)

		if (!host_irqs[temp])

			break;

	}

	if (temp) {