Commit ea28502d authored Jun 09, 2006 by Bjorn Helgaas Committed by Greg Kroah-Hartman Jun 21, 2006

[PATCH] PCI: fix to pci ignore pre-set 64-bit bars on 32-bit platforms



When we detect a 64-bit pre-set address in a BAR on a 32-bit platform,
we disable it and treat it as if it had been unset, thus allowing the
general address assignment code to assign a new address to it when the
device is enabled.  This can happen either if the firmware assigns
64-bit addresses; additionally, some cards have been found "in the
wild" which do not come out of reset with all the BAR registers set to
zero.

Unfortunately, the patch that implemented this tested the low part of
the address instead of the high part of the address.  This patch fixes
that.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 17d6dc8f

drivers/pci/probe.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -199,7 +199,7 @@ static void pci_read_bases(struct pci_dev *dev, unsigned int howmany, int rom)
	printk(KERN_ERR "PCI: Unable to handle 64-bit BAR for device %s\n", pci_name(dev));		printk(KERN_ERR "PCI: Unable to handle 64-bit BAR for device %s\n", pci_name(dev));
	res->start = 0;		res->start = 0;
	res->flags = 0;		res->flags = 0;
	} else if (l) {		} else if (lhi) {
	/* 64-bit wide address, treat as disabled */		/* 64-bit wide address, treat as disabled */
	pci_write_config_dword(dev, reg, l & ~(u32)PCI_BASE_ADDRESS_MEM_MASK);		pci_write_config_dword(dev, reg, l & ~(u32)PCI_BASE_ADDRESS_MEM_MASK);
	pci_write_config_dword(dev, reg+4, 0);		pci_write_config_dword(dev, reg+4, 0);