Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e96a4105 authored by Viresh Kumar's avatar Viresh Kumar Committed by Rafael J. Wysocki
Browse files

cpufreq: s3cx4xx: Use generic cpufreq routines 



Most of the CPUFreq drivers do similar things in .exit() and .verify() routines
and .attr. So its better if we have generic routines for them which can be used
by cpufreq drivers then.

This patch uses these generic routines in the s3cx4xx driver.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Acked-by: default avatarKukjin Kim <kgene.kim@samsung.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent bf36e48d

drivers/cpufreq/s3c2416-cpufreq.c

+2 −17
Original line number Original line Diff line number Diff line
@@ -87,16 +87,6 @@ static struct cpufreq_frequency_table s3c2450_freq_table[] = { 
	{ 0, CPUFREQ_TABLE_END },

	{ 0, CPUFREQ_TABLE_END },

};

};





static int s3c2416_cpufreq_verify_speed(struct cpufreq_policy *policy)

{

	struct s3c2416_data *s3c_freq = &s3c2416_cpufreq;



	if (policy->cpu != 0)

		return -EINVAL;



	return cpufreq_frequency_table_verify(policy, s3c_freq->freq_table);

}



static unsigned int s3c2416_cpufreq_get_speed(unsigned int cpu)

static unsigned int s3c2416_cpufreq_get_speed(unsigned int cpu)

{

{

	struct s3c2416_data *s3c_freq = &s3c2416_cpufreq;

	struct s3c2416_data *s3c_freq = &s3c2416_cpufreq;
@@ -516,19 +506,14 @@ static int __init s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy) 
	return ret;

	return ret;

}

}





static struct freq_attr *s3c2416_cpufreq_attr[] = {

	&cpufreq_freq_attr_scaling_available_freqs,

	NULL,

};



static struct cpufreq_driver s3c2416_cpufreq_driver = {

static struct cpufreq_driver s3c2416_cpufreq_driver = {

	.flags          = 0,

	.flags          = 0,

	.verify		= s3c2416_cpufreq_verify_speed,

	.verify		= cpufreq_generic_frequency_table_verify,

	.target		= s3c2416_cpufreq_set_target,

	.target		= s3c2416_cpufreq_set_target,

	.get		= s3c2416_cpufreq_get_speed,

	.get		= s3c2416_cpufreq_get_speed,

	.init		= s3c2416_cpufreq_driver_init,

	.init		= s3c2416_cpufreq_driver_init,

	.name		= "s3c2416",

	.name		= "s3c2416",

	.attr		= s3c2416_cpufreq_attr,

	.attr		= cpufreq_generic_attr,

};

};





static int __init s3c2416_cpufreq_init(void)

static int __init s3c2416_cpufreq_init(void)

drivers/cpufreq/s3c24xx-cpufreq.c

+0 −9
Original line number Original line Diff line number Diff line
@@ -416,14 +416,6 @@ static int __init s3c_cpufreq_initclks(void) 
	return 0;

	return 0;

}

}





static int s3c_cpufreq_verify(struct cpufreq_policy *policy)

{

	if (policy->cpu != 0)

		return -EINVAL;



	return 0;

}



#ifdef CONFIG_PM

#ifdef CONFIG_PM

static struct cpufreq_frequency_table suspend_pll;

static struct cpufreq_frequency_table suspend_pll;

static unsigned int suspend_freq;

static unsigned int suspend_freq;
@@ -473,7 +465,6 @@ static int s3c_cpufreq_resume(struct cpufreq_policy *policy) 




static struct cpufreq_driver s3c24xx_driver = {

static struct cpufreq_driver s3c24xx_driver = {

	.flags		= CPUFREQ_STICKY,

	.flags		= CPUFREQ_STICKY,

	.verify		= s3c_cpufreq_verify,

	.target		= s3c_cpufreq_target,

	.target		= s3c_cpufreq_target,

	.get		= s3c_cpufreq_get,

	.get		= s3c_cpufreq_get,

	.init		= s3c_cpufreq_init,

	.init		= s3c_cpufreq_init,

drivers/cpufreq/s3c64xx-cpufreq.c

+1 −9
Original line number Original line Diff line number Diff line
@@ -54,14 +54,6 @@ static struct cpufreq_frequency_table s3c64xx_freq_table[] = { 
};

};

#endif

#endif





static int s3c64xx_cpufreq_verify_speed(struct cpufreq_policy *policy)

{

	if (policy->cpu != 0)

		return -EINVAL;



	return cpufreq_frequency_table_verify(policy, s3c64xx_freq_table);

}



static unsigned int s3c64xx_cpufreq_get_speed(unsigned int cpu)

static unsigned int s3c64xx_cpufreq_get_speed(unsigned int cpu)

{

{

	if (cpu != 0)

	if (cpu != 0)
@@ -264,7 +256,7 @@ static int s3c64xx_cpufreq_driver_init(struct cpufreq_policy *policy) 




static struct cpufreq_driver s3c64xx_cpufreq_driver = {

static struct cpufreq_driver s3c64xx_cpufreq_driver = {

	.flags          = 0,

	.flags          = 0,

	.verify		= s3c64xx_cpufreq_verify_speed,

	.verify		= cpufreq_generic_frequency_table_verify,

	.target		= s3c64xx_cpufreq_set_target,

	.target		= s3c64xx_cpufreq_set_target,

	.get		= s3c64xx_cpufreq_get_speed,

	.get		= s3c64xx_cpufreq_get_speed,

	.init		= s3c64xx_cpufreq_driver_init,

	.init		= s3c64xx_cpufreq_driver_init,