Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e919cfd4 authored by John Stultz's avatar John Stultz
Browse files

time: Avoid scary backtraces when warning of > 11% adj 



Folks have been getting a number of warnings about time
adjustments > 11%. The WARN_ON leaves a big useless backtrace
so this patch removes it for a printk_once().

I'm still working to narrow down the cause of the > 11% adjustment.

Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
parent ad30dfa9

kernel/time/timekeeping.c

+6 −4
Original line number Diff line number Diff line
@@ -869,13 +869,15 @@ static void timekeeping_adjust(s64 offset) 
	} else /* No adjustment needed */

		return;



	WARN_ONCE(timekeeper.clock->maxadj &&

			(timekeeper.mult + adj > timekeeper.clock->mult +

						timekeeper.clock->maxadj),

			"Adjusting %s more then 11%% (%ld vs %ld)\n",

	if (unlikely(timekeeper.clock->maxadj &&

			(timekeeper.mult + adj >

			timekeeper.clock->mult + timekeeper.clock->maxadj))) {

		printk_once(KERN_WARNING

			"Adjusting %s more than 11%% (%ld vs %ld)\n",

			timekeeper.clock->name, (long)timekeeper.mult + adj,

			(long)timekeeper.clock->mult +

				timekeeper.clock->maxadj);

	}

	/*

	 * So the following can be confusing.

	 *