Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit e8d8b98c authored by Markus Elfring's avatar Markus Elfring Committed by Mark Brown
Browse files

ASoC: cs42l56: Improve two size determinations in cs42l56_i2c_probe() 



Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 277631cc

sound/soc/codecs/cs42l56.c

+2 −5
Original line number Diff line number Diff line
@@ -1190,9 +1190,7 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client, 
	unsigned int alpha_rev, metal_rev;

	unsigned int reg;



	cs42l56 = devm_kzalloc(&i2c_client->dev,

			       sizeof(struct cs42l56_private),

			       GFP_KERNEL);

	cs42l56 = devm_kzalloc(&i2c_client->dev, sizeof(*cs42l56), GFP_KERNEL);

	if (cs42l56 == NULL)

		return -ENOMEM;

	cs42l56->dev = &i2c_client->dev;
@@ -1207,8 +1205,7 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client, 
	if (pdata) {

		cs42l56->pdata = *pdata;

	} else {

		pdata = devm_kzalloc(&i2c_client->dev,

				     sizeof(struct cs42l56_platform_data),

		pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata),

				     GFP_KERNEL);

		if (!pdata)

			return -ENOMEM;