Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e7b18ede authored by Mike Miller's avatar Mike Miller Committed by Linus Torvalds
Browse files

cciss: set max scatter gather entries to 32 on P600 



At one time we used to set the maximum number of scatter gather elements
on all Smart Array controllers to 32.  At some point in time the
firmware began to write the "appropriate" value for each controller into
the config table.  The cciss driver would then read that and set
h->maxsgentries.

        h->maxsgentries = readl(&(h->cfgtable->MaxSGElements);

On the P600 that value is 544.  Under some workloads a significant
performance reduction may result.  This patch forces the P600 to use
only 32 scatter gather elements.  Other controllers are not affected.

Signed-off-by: default avatarMike Miller <mike.miller@hp.com>
Signed-off-by: default avatarDwight (Bud) Brown <bubrown@redhat.com>
Signed-off-by: default avatarTomas Henzl <thenzl@redhat.com>
Acked-by: default avatarStephen M. Cameron <steve.cameron@hp.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c86db975

drivers/block/cciss.c

+7 −0
Original line number Diff line number Diff line
@@ -4257,6 +4257,13 @@ static void cciss_find_board_params(ctlr_info_t *h) 
	cciss_get_max_perf_mode_cmds(h);

	h->nr_cmds = h->max_commands - 4 - cciss_tape_cmds;

	h->maxsgentries = readl(&(h->cfgtable->MaxSGElements));

	/*

	 * The P600 may exhibit poor performnace under some workloads

	 * if we use the value in the configuration table. Limit this

	 * controller to MAXSGENTRIES (32) instead.

	 */

	if (h->board_id == 0x3225103C)

		h->maxsgentries = MAXSGENTRIES;

	/*

	 * Limit in-command s/g elements to 32 save dma'able memory.

	 * Howvever spec says if 0, use 31