Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e7507ed9 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Linus Torvalds
Browse files

[PATCH] uniput - fix crash on SMP 



Only signal completion after marking request slot as free, otherwise other
processor can free request structure before we finish using it.

Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 5cc9eeef

drivers/input/misc/uinput.c

+2 −2
Original line number Diff line number Diff line
@@ -90,11 +90,11 @@ static inline int uinput_request_reserve_slot(struct uinput_device *udev, struct 


static void uinput_request_done(struct uinput_device *udev, struct uinput_request *request)

{

	complete(&request->done);



	/* Mark slot as available */

	udev->requests[request->id] = NULL;

	wake_up_interruptible(&udev->requests_waitq);



	complete(&request->done);

}



static int uinput_request_submit(struct input_dev *dev, struct uinput_request *request)