Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5091842 authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Kumar Gala
Browse files

[POWERPC] 85xx: mpc85xx_ads: add in missing of_node_put() 



Add in missing of_node_put() after cpm2_pic_init(). This and other coding
style cleanups as suggested by Stephen Rothwell.

Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarKumar Gala <galak@kernel.crashing.org>
parent d7584ed2

arch/powerpc/platforms/85xx/mpc85xx_ads.c

+6 −6
Original line number Diff line number Diff line
@@ -52,9 +52,9 @@ static void cpm2_cascade(unsigned int irq, struct irq_desc *desc) 
{

	int cascade_irq;



	while ((cascade_irq = cpm2_get_irq()) >= 0) {

	while ((cascade_irq = cpm2_get_irq()) >= 0)

		generic_handle_irq(cascade_irq);

	}



	desc->chip->eoi(irq);

}
@@ -70,8 +70,7 @@ static void __init mpc85xx_ads_pic_init(void) 
#endif



	np = of_find_node_by_type(np, "open-pic");



	if (np == NULL) {

	if (!np) {

		printk(KERN_ERR "Could not find open-pic node\n");

		return;

	}
@@ -100,6 +99,7 @@ static void __init mpc85xx_ads_pic_init(void) 
	irq = irq_of_parse_and_map(np, 0);



	cpm2_pic_init(np);

	of_node_put(np);

	set_irq_chained_handler(irq, cpm2_cascade);

#endif

}
@@ -112,7 +112,7 @@ struct cpm_pin { 
	int port, pin, flags;

};



static struct cpm_pin mpc8560_ads_pins[] = {

static const struct cpm_pin mpc8560_ads_pins[] = {

	/* SCC1 */

	{3, 29, CPM_PIN_OUTPUT | CPM_PIN_PRIMARY},

	{3, 30, CPM_PIN_OUTPUT | CPM_PIN_SECONDARY},