Commit e46dcbb1 authored May 30, 2018 by Dan Carpenter Committed by Takashi Iwai May 30, 2018

ALSA: xen-front: freeing an error pointer



kfree() doesn't accept error pointers so I've set "str" to NULL on these
paths.

Fixes: fd3b3604 ("ALSA: xen-front: Read sound driver configuration from Xen store")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 986376b6

sound/xen/xen_snd_front_cfg.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -306,6 +306,7 @@ static int cfg_get_stream_type(const char *path, int index,
		str = xenbus_read(XBT_NIL, stream_path, XENSND_FIELD_TYPE, NULL);
		if (IS_ERR(str)) {
		ret = PTR_ERR(str);
		str = NULL;
		goto fail;
		}

		@@ -347,6 +348,7 @@ static int cfg_stream(struct xen_snd_front_info *front_info,
		str = xenbus_read(XBT_NIL, stream_path, XENSND_FIELD_TYPE, NULL);
		if (IS_ERR(str)) {
		ret = PTR_ERR(str);
		str = NULL;
		goto fail;
		}