Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4459e16 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Mauro Carvalho Chehab
Browse files

[media] drxk: Does not unlock mutex if sanity check failed in scu_command() 



If sanity check fails in scu_command(), goto error leads to unlock of
an unheld mutex. The check should not fail in reality, but it nevertheless
worth fixing.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Cc: stable@kernel.org
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 3626479e

drivers/media/dvb/frontends/drxk_hard.c

+4 −2
Original line number Diff line number Diff line
@@ -1520,8 +1520,10 @@ static int scu_command(struct drxk_state *state, 
	dprintk(1, "\n");



	if ((cmd == 0) || ((parameterLen > 0) && (parameter == NULL)) ||

	    ((resultLen > 0) && (result == NULL)))

		goto error;

	    ((resultLen > 0) && (result == NULL))) {

		printk(KERN_ERR "drxk: Error %d on %s\n", status, __func__);

		return status;

	}



	mutex_lock(&state->mutex);