Commit e3f3d7ab authored Sep 05, 2018 by Dan Carpenter Committed by Guenter Roeck Sep 05, 2018

hwmon: (nct6775) Set weight source to zero correctly



This is dead code because j can never be 1 at this point.  We had
intended to just test if the bit was clear.

Fixes: bbd8decd ("hwmon: (nct6775) Add support for weighted fan control")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 57361846

drivers/hwmon/nct6775.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1558,7 +1558,7 @@ static void nct6775_update_pwm(struct device *dev)
		reg = nct6775_read_value(data, data->REG_WEIGHT_TEMP_SEL[i]);
		data->pwm_weight_temp_sel[i] = reg & 0x1f;
		/* If weight is disabled, report weight source as 0 */
		if (j == 1 && !(reg & 0x80))
		if (!(reg & 0x80))
		data->pwm_weight_temp_sel[i] = 0;

		/* Weight temp data */